OpenWaterFoundation / owf-app-infomapper-ng

Open Water Foundation InfoMapper web application for menu-driven maps and visualizations, using Angular
GNU General Public License v3.0
1 stars 2 forks source link

DateValue file with Properties causes exception #326

Closed smalers closed 3 years ago

smalers commented 4 years ago

The DateValueTS code has a bug parsing Properties line. Below is a chunk of a file that causes an exception and consequently no graph is displayed. I commented out the code in order to move on.

Delimiter   = " "
NumTS       = 1
TSID        = "Muni:Yampa.Model.Population-Forecast.Year.Baseline"
Alias       = "Yampa-Muni-Population-Forecast-Baseline"
Description = "Yampa municipality population forecast, SetFromTS, *Yampa Population-Total, /Routt Population-Total, SetFromTS, fill repeat forward"
DataType    = "Population-Forecast"
Units       = "persons"
MissingVal  = NaN
DataFlags   = true
Properties_1 = {County:"Routt",CountyNum:"1",County_CSV_NoSpace:"Routt"}
Start       = 2019
End         = 2050

Below is another example where the CSV contains commas:

Delimiter   = " "
NumTS       = 1
TSID        = "Muni:Windsor.Model.Population-Forecast.Year.Baseline"
Alias       = "Windsor-Muni-Population-Forecast-Baseline"
Description = "Windsor municipality total population (forecast only), SetFromTS + Windsor-Weld municipality population forecast, SetFromTS, *Windsor-Weld Population-Total, /Weld Population-Total, SetFromTS, fill repeat forward"
DataType    = "Population-Forecast"
Units       = "persons"
MissingVal  = NaN
DataFlags   = true
Properties_1 = {CountyNum:"2",County_CSV_NoSpace:"Larimer,Weld"}
Start       = 2019
End         = 2050
Nightsphere commented 4 years ago

The push for this has been merged, and I believe is working correctly. I'll wait until Steve can do some more testing before this is closed.

Nightsphere commented 3 years ago

This hasn't given any issue for a while, and can be opened if run into again. Closing the issue.