OpenWaterFoundation / owf-app-infomapper-ng

Open Water Foundation InfoMapper web application for menu-driven maps and visualizations, using Angular
GNU General Public License v3.0
1 stars 2 forks source link

Clarify text on data table search with no match #407

Open smalers opened 3 years ago

smalers commented 3 years ago

It is easy to forget which radio button was pressed when doing the search. Change the text to the following and note the line breaks for clarity. Also, I think the Find from address should be changed to Search using address since it is a "search" tool and that is the word that is used elsewhere.

When searching data:

No data matched the filter "518 peterson street, fort collins, co " Did you intend to search using an address? If so, select Search using address and press Enter.

When searching address:

No address matched the filter "abc fifth street, junky city, co" Did you intend to search the data? If, so, select Search data and press Enter. Matches will only be found if the address location is within a polygon for the layer.

Note for the above that if search is implemented for point and line layers with radius, the third line can be changed to something like "Matches will only be found if the address location is within the radius distance of layer features.

Also, I tried an invalid address as below and the search results did not seem to refresh. The results from the previous search remain. The console output is shown below. When I tried a more complete bad address it seemed to work as in the second image.

image

image

Nightsphere commented 1 year ago

The changes for this have been updated and changes the wording, as well as fixes the error issue when searching a bad address with GeoCodio. This has been done in the AppDev repo where the code lives. All Angular and Cypress tests pass successfully. I will wait to close the issue until I push up the local changes to the remote.