search

OpenWaterFoundation / owf-app-infomapper-ng

Open Water Foundation InfoMapper web application for menu-driven maps and visualizations, using Angular
GNU General Public License v3.0
1 stars 2 forks source link

Remove map-components folder #418

Closed Nightsphere closed 2 years ago

Nightsphere commented 2 years ago

Technically a dehancement, the map-components/ needs to be removed, as the Map Component and other relevant files are in the Common library, and have been for some time.

The reason it still exists, is because there is one function being used from the Map Service in the NavBar Component. This can be moved to the Infomapper App Service easily enough, but I'm a little concerned about if it will effect something on the Common library side. It has a Map Service as well, and might get confused if it looks for a variable that has been moved.

Because of this possible hiccup, I've made this into its own issue so I can create the proper testing environment.

Nightsphere commented 2 years ago

Successfully removed the folder and moved the MapService functions that were still being used in the AppService. Closing this issue.