OpenWaterFoundation / owf-app-snodas-ng

Open Water Foundation SNODAS snowpack user interface built with Angular
0 stars 0 forks source link

Feedback on latest 2.0.0 version #19

Open smalers opened 3 years ago

smalers commented 3 years ago

I implemented the build-util/copy-to-amazon-s3.sh script to copy the application to OWF's S3 cloud. See the following links. Something similar will need to be done for Google Cloud Platform, and I have more experience with that now and can automate better than we did before. I'll also define a redirect so that the URL without version can be found.

Here is feedback:

  1. Application:
    1. About version is what I am currently using to get the application version for the upload script. I'd prefer to get from a property in app-config.json, as discussed in a separate issue.
    2. Need a configuration property for the application title shown in the application, similar to InfoMapper. This will allow OWF to use "SNODAS Tools" and the State to use "CDSS SNODAS Tools".
    3. Change the title shown in the tab to "SNODAS | Daily Snow Data". The current tab is too long and gets truncated.
    4. Need a configuration property for favicon to allow setting the icon to OWF logo or State logo, depending on deployment.
  2. Map:
    1. Looks good. I have suggestions but will add as separate issues and we need to get other funding to make more enhancements.
    2. When viewing another tab and then click on Map, it seems that the application totally refreshes. Can this be made more seamless?
  3. Animation:
    1. Disable play button until dates are entered.
    2. See other issue about quick picks on dates. This can be implemented as a choice. Once selected, auto-populate the start and date dates. The Java TimeUtil class has some functions for dealing with water year and calendar year. This would save a lot of typing for users.
    3. Is it possible to allow dragging the slider to a desired date? That would be useful. Add as a separate issue and do later.
  4. Documentation pages:
    1. Did my feedback on hardcopy documentation get implemented? Some of the comments below seem to be things I've already mentioned. Now that I have a development environment working, I just edited the files myself.
    2. About had the same content repeated multiple times. I fixed.
    3. Implement improved scrollbar on the far right.
    4. Seems like bullet font size is bigger than normal paragraph. I think I commented on this to Sofia previously. The normal paragraph font seems a bit small so maybe what is used for bullets is what the default should be?
    5. Clicking on external link should open a new tab like InfoMapper. It is too easy to close the application and get messed up with browser back button.
    6. Does markdown link without http or https automatically try each? It seems to work but research indicates that the protocol should be included. I included the protocol in all URLs and examples.
    7. Apparently the user and developer manuals only exist on OWF website. I'll figure out whether to install on a State server.
    8. Many links used HTML embedded in Markdown. I switched to markdown syntax. See above comment about automatically opening to a new tab for external links.
  5. Deployment:
    1. Need to decide what to do with the sample/test data. Maybe need a script similar to InfoMapper to strip out. I commented out the step in the copy script but can enable. Need Josh to indicate what files should be removed.
    2. Or, maybe need a way to switch to test data in the deployed environment, but using actual data would seem to be better once deployed.