search

OpenWaterFoundation / owf-app-viz-demo-ng

Open Water Foundation application to test different visualizations in Angular
0 stars 0 forks source link

Implement HashLocationStrategy #10

Open smalers opened 3 years ago

smalers commented 3 years ago

Other OWF applications are using the HashLocationStrategy. This has helped to provide more structure to the URLs and routing. For example, for InfoMapper, any map is found under #/map and normal content pages are found under #/contentPage. The InfoMapper configuration file defines menus with an id property, which is used at the end of the URL.

I suggest that this be implemented for the demonstration application. Josh can help if there are questions. The routing can then implement some logical URL mapping. I can comment on this more once other issues related to file organization are addressed. For example, the URLs might make sense to look like:

gsofia23 commented 3 years ago

Hash Location Strategy implemented. TODO: include logical url mapping to display charting package

smalers commented 3 years ago

I think the routing URLs need some work based on my original comment. For example, the path should be something like:

#/plotly/tstool-graph-month-line

The above would clearly have delineation between the library and the examples for that library. The current plotly-tstool-graph is too generic and a flat naming does not scale well. I'm going to update other issues with specific feedback.

smalers commented 3 years ago

See other issue comments. Remove "demo" from URLs since it is redundant. Add "line", etc. as needed to completely describe the example.