search

OpenWaterFoundation / owf-app-viz-demo-ng

Open Water Foundation application to test different visualizations in Angular
0 stars 0 forks source link

ChartJS examples feedback #16

Open smalers opened 3 years ago

smalers commented 3 years ago

Plotly is now the default in InfoMapper, so we will be spending less time on ChartJS. However, I'd like the previous examples to be functional and update the menus consistently. Here is my feedback on the ChartJS examples:

  1. Change the URL to /chartjs/ followed by the example, for example /chartjs/basic-month-line-modal.
  2. The basic example does not work. Either make it work, or remove it. Add a separate issue if necessary. Change the URL as in the previous item and menu to Basic Example: Month, Line, Modal, but without seeing it work, I don't know if I am suggesting the correct words.
  3. Change the second menu to SNODAS: Day, Line and URL to `/chartjs/snodas-day-line. This example is also broken so need to fix.
  4. Change the third menu to TSTool Graph: Month, Line and URL to `/chartjs/tstool-month-line. The main title does not look like what is coming from a TSTool configuration file. I'm mainly interested in getting the menus cleaned up since I want similar menus for the other packages.

By following the URL and menu patterns above, we have flexibility with other examples. If necessary, the URLs and menus can be further modified if ambiguous.

gsofia23 commented 3 years ago

URL paths updated for each ChartJS demo. Broken examples, Basic example and TSTool graph example, fixed. SNODAS demo fix in progress.

gsofia23 commented 3 years ago

Snodas demo dialog fixed and consistent with other popups

smalers commented 3 years ago

As indicated for plotly feedback, please remove "demo" from menu and URLs because it is redundant. Change the menu wording as per the original issue post. I would like to see from a menu label the data interval and chart type because we are going to add more examples.