search

OpenWebAdvocacy / website

Source code for the Open Web Advocacy website.
https://open-web-advocacy.org/
MIT License
33 stars 24 forks source link

Language switcher only works on home page #182

Open mtom55 opened 6 hours ago

mtom55 commented 6 hours ago

Type of Change

Summary

image

The language switcher doesn't work on other pages on the site, other than the home page

shuuji3 commented 4 hours ago

I can see the language switcher works as expected between translated pages. For example, both the "Home" and "Get Involved" pages have Spanish translations:

I think this is an intuitive implementation.

On the other hand, the "Blog" page has no Spanish translation yet but it shows two links, both for the English page:

screenshot of news page with language selector dialog showing English and Spanish News - Open Web Advocacy - https://open-web-advocacy.org/blog/

I'd suggest either 1) showing only translated pages in the Languages selector dialog or 2) showing both language names but disabling the link to a non-existing page and adding some label or icon indicating that this page hasn't been translated yet.

Also, the Spanish home page has mixed links; some links navigate to the Spanish page and others to the English page. However, users cannot see clearly the difference between them. Maybe we can put a label such as [en] next to the links to an untranslated page.