search

OpenWebconcept / plugin-openpub-base

The OpenPub publication platform
https://openwebconcept.nl/bouwblokken
GNU General Public License v3.0
1 stars 3 forks source link

Add to EP mapping properties instead of overwriting them #3

Open coenjacobs opened 1 year ago

coenjacobs commented 1 year ago

The properties key of the mappings key in the mapping array already has values provided by the ElasticPress mapping. In the old situation, that entire key was overwritten, instead of adding the custom mappings to the properties.

Original PR from Bitbucket (for reference): https://bitbucket.org/openwebconcept/plugin-openpub-base/pull-requests/20

Fixes issue with custom mapping that has been reported before (for reference, link to original repository reported issue): https://bitbucket.org/openwebconcept/plugin-openpub-base/issues/4/elasticsearch-custom-mapping

coenjacobs commented 1 year ago

@mvdhoek1 @SimonvanWijhe This PR was left open on the previous home of the repository. I've ported it over and provided reference links to track back the conversation. Can this still be reviewed, please?

mvdhoek1 commented 1 year ago

When you're ready to merge don't forget the version bumps in src/OpenPub/Foundation/Plugin.php and openpub-base.php + changelog