OpenWonderLabs / SwitchBotAPI

SwitchBot Open API Documents
877 stars 73 forks source link

API always returning success message even when connection fails #189

Open baty0man opened 1 year ago

baty0man commented 1 year ago

Current Situation

When using the switchbot API to control my switchbot, I always get a successful response even though sometime it doesn't work. When I look at the logs of that particular switchbot, I can see the error message saying "Failed from connect to device, try again"

I understand that sometime the Bluetooth connection from the switchbot hub to the switchbot fails, however I would like the API to return an error message instead of a success message.

Proposed Change

I would like the API to return an error message when the connection fails. At the minute it always return a success message.

Additional Context

No response

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

baty0man commented 1 year ago

Still an issue

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

baty0man commented 1 year ago

Still an issue

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

baty0man commented 1 year ago

Still an issue

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

baty0man commented 1 year ago

Still an issue

edsaavedra84 commented 1 year ago

I agree, this is really annoying making the API somewhat unreliable, I have the exact same problem as you, I even have the switchbot hub very close to a press and curtain bot, and sometimes I get the described connection error.

Screenshot_20230905-231825.png

I suppose I can check the status of the curtain after a rest call to do a retry, but for the Press bot its a deal breaker since I use it in button presser mode

elf-bot commented 1 year ago

I have the same issue with an IR-paired Airconditioner. I'm getting a success messaged although I see on the logs it failed with this message: "Failed to connect device, try again.". But it works fine sometimes.

The range is not an issue since it's directly face to face. I tried adding a repeating action and a 20second delay between them but neither time worked.

The problem with IR devices especially is that there's no way to get the device's status, so it's a fully blocking issue. The solution ideally either respond with the accurate success code, or at least provide access to the Logs through the API.

pisabird commented 1 year ago

How can I receive a response via the API to determine if the SwitchBot Bot device is busy? In the app, I receive a 'bingo' when it is successful, or a notification that the device is busy in case of a failure. But when I make an api call then I only get success 100, even if the bot is busy.

davidsak commented 1 day ago

I’m having this issue. It’s happened in the past and then stopped and just recently started again. It’s happening across several hubs all when trying to control an air conditioner device.