OpenWonderLabs / homebridge-switchbot

The Homebridge SwitchBot plugin allows you to access your SwitchBot Device(s) from HomeKit. Homebridge.
https://openwonderlabs.github.io/homebridge-switchbot/
ISC License
239 stars 51 forks source link

Bug: "Other" IR Devices send incorrect commands if repeated #314

Closed jonzhan closed 2 years ago

jonzhan commented 2 years ago

Describe The Bug

"Other" IR Devices send incorrect commands if repeated

To Reproduce

Try to turn off an "Other" IR device which is already off. It will turn on.

Expected behavior

Nothing should happen or the Off command should be retransmitted.

Relevant log output

[15/04/2022, 19:24:51] [SwitchBot] Other: Aircon Sending request to SwitchBot API. command: Off, parameter: default, commandType: customize
[15/04/2022, 19:25:15] [SwitchBot] Other: Aircon Sending request to SwitchBot API. command: On, parameter: default, commandType: customize

Config for homebridge-switchbot

{
    "deviceId": "xxxxxxxxx",
    "configRemoteType": "Fan",
    "other": {
        "deviceType": "Fan",
        "commandOff": "Off",
        "commandOn": "On"
    },
        "logging": "debug"
}

Screenshots

No response

Device & Model

Raspberry Pi 3

Node.js Version

v16.13.0

NPM Version

v8.1.0

Homebridge Version

v1.4.0

Homebridge Switchbot Plugin Version

v1.12.8

Homebridge Config UI X Plugin Version

v4.42.0

Operating System

Raspbian

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 2 years ago

This issue has been automatically closed because it has not had recent activity. Thank you for your contributions.