search

OpenWonderLabs / homebridge-switchbot

The Homebridge SwitchBot plugin allows you to access your SwitchBot Device(s) from HomeKit. Homebridge.
https://openwonderlabs.github.io/homebridge-switchbot/
ISC License
239 stars 51 forks source link

Fix a bug where Switchbot Curtain 3 models would fail to update over BLE #989

Closed manavgabhawala closed 3 months ago

manavgabhawala commented 3 months ago

:recycle: Current situation

A hardcoded value in the code meant that Switchbot Curtain 3 models would always fail to update their state if a BLEPush was triggered in the code

:bulb: Proposed solution

Use the device's BLE model instead of a hardcoded value

:gear: Release Notes

N/A

:heavy_plus_sign: Additional Information

N/A

Testing

No tests added, but manually tested with real world device and it does seem to be working correctly now.

Reviewer Nudging

N/A simple one line change.

donavanbecker commented 3 months ago

this is already fixed in the beta branch.

donavanbecker commented 3 months ago

v3.5.1 has been released, please install and let me know if this has been resolved.