search

OpenWonderLabs / node-switchbot

The node-switchbot is a Node.js module which allows you communicate with SwitchBot Devices over BLE or OpenAPI
https://openwonderlabs.github.io/node-switchbot/
ISC License
71 stars 25 forks source link

Fix TypeScript issues #239

Closed dnicolson closed 6 months ago

dnicolson commented 6 months ago

:recycle: Current situation

There are ParameterChecker issues after the TypeScript migration and some TypeScript issues.

:bulb: Proposed solution

Fix the issues and import types from Noble. Enforce no explicit any in ESLint.

There are some TypeScript errors related to the _state property that will go away after https://github.com/abandonware/noble/pull/333 is merged.

donavanbecker commented 6 months ago

Is this ready to go?

dnicolson commented 6 months ago

I'd say so, the TypeScript errors will automatically be fixed upstream after the next release.

It's probably better to get it merged before it gets too old and possibly out of date.

donavanbecker commented 6 months ago

I rebased to beta-2.1.0

Can you fix conflicts?