OpenWork-NZ / core-geonetwork

GeoNetwork repository

GNU General Public License v2.0

0 stars 3 forks source link

Associated Resources, OnlineResource is flaky #24

Closed alcinnz closed 3 years ago

alcinnz commented 3 years ago

Particularly in the "link a" field. "link a" may report the wrong thing on retrieval from associated resources, at least for "additional documentation". Example additional issues with "Associated resources" tool

alcinnz commented 3 years ago

8

ByronCinNZ commented 3 years ago

Associated Resources should be renamed to "Linked Resources" as associated resource has particular meaning as a ISO 19115 element

alcinnz commented 3 years ago

Merge with #38

Unclear what the issue we were having here is, it might have been fixed in latest geonetwork.

alcinnz commented 3 years ago

When linking a dataset to a service creates a record for both "Coupled Resource" & "Operates On". In "Full View" (nonedit) the name displayed for that "operates on" record is incorrect.

This seems to relate to the view.xsl file line 1002, calling gn-fn-render:getMetadataTitle(). The confusing thing here is that the ID passed is the same that correctly populates the href for the link. We're unclear where this XPath function is defined.

alcinnz commented 3 years ago

[x] Label changes: "Name of Coupled Resource" -> "Scoped Name" "Website" -> "Online Linkage" "OnLine resource" -> "Online resource"
[x] When you link a dataset to service it should autopopulate "Scoped Name", "Citation Title", Citation Online Linkage & Description (should read "Metadata for ...") as according to MDWG guidance for Coupled Resource.
[x] Also enable Coupled Resource to be populated through selection of a dataset, currently only Operates On gets populated.

alcinnz commented 3 years ago

Changed the $schema/loc/eng/labels.xml to fix poor labelling in commit 1e98c47bf64fea6022d0e5202847fad881639895

alcinnz commented 3 years ago

Files of interest:

web-ui/src/main/resources/catalog/components/edit/onlinesrc/OnlineSrcDirective.js is the main UI file for add link to service dialog. We'll mainly be editting this to change behaviour of "operated on", and to ensure that "coupled resource" is populated when editing a service record.
components/catalog/CatalogService.js provides some indication of available metadata fields.
resources/catalog/edit/EditorController.js sets many of the fields on the gnCurrentEdit global.
plugin/iso19115-3.2018/process/dataset-add.xsl actually populates the metadata XML. This is called directly by components/edit/onlinesrc/OnlineSrcService.js.

alcinnz commented 3 years ago

We captured the abstract in EditorController.js & stored it in gnCurrentEdit.

alcinnz commented 3 years ago

Cleanup passing information for abstract.

ByronCinNZ commented 3 years ago

Issue done for now. Likely need to revisit some aspects for workflow and styling