OpenXE-org / OpenXE

OpenXE - Free Open Source ERP based on Xentral
Other
53 stars 26 forks source link

PDF layout briefpapier #34

Closed OpenXE-ERP closed 1 year ago

OpenXE-ERP commented 1 year ago

www/lib/dokumente/class.briefpapier.php

Call of function Cell() is incorrect, suggest change function to typed paramers and correct all calls.

Actual:

$this->Cell(30,3,$this->app->erp->Beschriftung('dokument_zzglmwst').' '.$k.' %',0,'L','L'); //1

Korrekt:

$this->Cell(30,3,$this->app->erp->Beschriftung('dokument_zzglmwst').' '.$k.' %',0,0,'L'); //1

Also check which library is used and purge unused ones.

./www/lib/pdf/fpdf_3.php:871: function Cell($w, $h=0, $txt='', $border=0, $ln=0, $align='', $fill=false, $link='')

./www/lib/pdf/fpdf_org.php:576:function Cell($w, $h=0, $txt='', $border=0, $ln=0, $align='', $fill=false, $link='')

./www/lib/pdf/fpdf_2.php:807: function Cell($w,$h=0,$txt='',$border=0,$ln=0,$align='',$fill=0,$link='',$noln=false)

./www/lib/pdf/fpdf.php:721: function Cell($w,$h=0,$txt='',$border=0,$ln=0,$align='',$fill=0,$link='')

OpenXE-ERP commented 1 year ago
// Typed variables to get rid of the typos, $border omitted intenionally

function Cell_typed(int $w, int $h = 0, string $txt = '', $border = 0, int $ln = 0, string $align = '', bool $fill = false, string $link = '') { return($this->Cell($w,$h,$txt,$border,$ln,$align,$fill,$link)); }

OpenXE-ERP commented 1 year ago

8c1eb6c3ccf8800286101e1138ab0ffad9bff658