search

OpenXRay / xray-15

X-Ray Engine 1.5 expansion. Original version was used in S.T.A.L.K.E.R.: Clear Sky.
https://discord.gg/sjRMQwv
Other
168 stars 66 forks source link

Multi-threading #8

Open ghost opened 10 years ago

ghost commented 10 years ago

Any thoughts about making the project multi-threaded as well as possibly moving to a 64-bit exe?

nitrocaster commented 10 years ago

Moving to 64-bit - almost no serious problems.

As for multithreading - I have no idea for now. First priority is to fix bugs (lots of them), move original libraries out of the repository, organize includes and subdivide xrGame into multiple modules.

ghost commented 10 years ago

I understand. Multithreading is a big project, I just thought I'd throw it out there since CS is single-core mostly.

fagoatse commented 10 years ago

But is that really a bottleneck on modern CPUs? I think majority of slowdowns come from a very unoptimized renderer. MT might be difficult to achieve since xray was mostly written with a monolithic design in mind.
@nitrocaster is there any chance of seeing SoC code @ github? I'm aware that there's a very active Russian project out there but it uses svn and all commits/docs seem to be written in Russian so unfortunately potential contributors are deterred. CoP is also said to follow, any news on that?

andrew-boyarshin commented 10 years ago

@fagoatse Rendering is always bottleneck in all games I've ever seen. SoC sources, as far as I remember, present at BitBucket, but I don't remember repo name. But username is "stalker". @Swartz27 CS is not multithreaded - but it is not good - when we will complete all current tasks, we, I hope, will try to make it multicore and multithreaded.

nitrocaster commented 10 years ago

@fagoatse Don't think, profile it. As for 'very active Russian project', here are two public SoC repos: 1] https://xp-dev.com/sc/204486/HEAD 2] https://bitbucket.org/stalker/x-ray I nave no plans to mess with old SoC code - there were too many changes in CS and any work on SoC code is just wasting time.

Also there's a public CS repo: https://bitbucket.org/stalker/clearsky But I don't see any serious work there (just reckless mega-commits without any plans) (another thing is that I don't like bitbucket :) ) In fact, I haven't seen any good docs about x-ray sources.

nitrocaster commented 10 years ago

You'r wrong. Stalker has pretty complicated AI but pretty simple r1 renderer that runs so fast that GSC released a special patch that slows it down (to prevent some artefacts and GPU overheating). Another good example is Minecraft - really simple renderer but very complicated game logics.

andrew-boyarshin commented 10 years ago

@nitrocaster because nobody wants to dig deep in code, that was written in 2003-2004... :) And C++ is much harder and bigger than modern langs, like C# or Java, so, there aren't many coders, who understand XRay sources. I also think, that SoC is too old and featureless platform for editing and modding.

andrew-boyarshin commented 10 years ago

@nitrocaster

You'r wrong.

I don't think so. S.T.A.L.K.E.R. has r3 and r4 - they aren't so fast. I'm not talking about r1 - because it is really simple. Rendering on r3 is much more slow than on r1. AI runs fast enough - thanks to LuaJIT. Minecraft:

  1. Java(VM and other "cookies")
  2. Shitcode(written by one person at the beginning of dev)
  3. Huge number of additional libs(LWJGL and other 4+ libs)
  4. Renderer is not simple, as it is highly customizable.
nitrocaster commented 10 years ago

'Simple' means 'simple for hardware', that's it.

fagoatse commented 10 years ago

@nitrocaster I'll try to hook up https://github.com/CyberShadow/verysleepy and do some profiling when I find some time but without proper docs and actual comments its difficult to navigate through such a large codebase. At this point cleaning up and organizing things is more important than worrying about threading and such. And then again there are those rumours about CoP source getting leaked which might be even a better codebase to work on. However, working on 3 versions of the same engine seems like an even bigger waste of time and resources. The main goal should be to turn xray into equivalent of ioquake and loading SoC, CS and CoP as assets.

nitrocaster commented 10 years ago

Exactly. Complicated and long-term modifications will be easier once we have organized codebase.

Rumours. Loxotron (a user that published leaked sources) wrote (literally) "CoP sources will be later on".

Honestly, I planned to fix bugs and tweak multiplayer, but ... whatever :) Another reasonable task is to get editors compiled completely in MSVC.

nitrocaster commented 10 years ago

Also, for profiling: you can use Visual Studio profiler.

ghost commented 10 years ago

"Rumours. Loxotron (a user that published leaked sources) wrote (literally) "CoP sources will be later on"."

I sent him a PM about the COP source and he told me that his NDA with GSC ends in the Fall and he plans on an October release most likely.