search

OpenXRay / xray-16

Improved version of the X-Ray Engine, the game engine used in the world-famous S.T.A.L.K.E.R. game series by GSC Game World. Join OpenXRay! ;)
https://discord.gg/sjRMQwv
Other
2.97k stars 456 forks source link

Black line bug #1629

Open yohjimane opened 7 months ago

yohjimane commented 7 months ago

Describe the bug Seemingly based on camera angle, black line(s) can appear on the screen. Reproducing is extremely difficult unless you randomly see it happen, and can focus your mouse on the exact position. In the attached video, i had to turn my mouse sensitivity down to .001 to pin down the spot.

I did also capture this in renderdoc, in OXR Gunslinger installation, but unfortunately we didn't find any clues as to what the issue is there.

To Reproduce Steps to reproduce the behavior:

  1. Get really lucky

Expected behavior There shouldn't be any black lines

Screenshots, videos

https://github.com/OpenXRay/xray-16/assets/11345783/2abbb1e7-e52c-4ae7-8959-781a112efec6

Desktop (please complete the following information):

Additional context So far I've only been able to repro the issue on r4 with new_shader_support enabled. Not sure if it's an issue on other renders / vanilla r4

SkyLoaderr commented 6 months ago

As a temporary solution, you can change the hbox_verts[24] variable (in Layers/xrRender/dxEnvironmentRender.cpp) by replacing

    {-1.f, 0.f, -1.f}, {-1.f, -1.f, -1.f},  // half
    {1.f, 0.f, -1.f}, {1.f, -1.f, -1.f},    // half
    {1.f, 0.f, 1.f}, {1.f, -1.f, 1.f},      // half
    {-1.f, 0.f, 1.f}, {-1.f, -1.f, 1.f}     // half

with

    {-1.f, -0.01f, -1.f}, {-1.f, -1.f, -1.f},  // half
    {1.f, -0.01f, -1.f}, {1.f, -1.f, -1.f}, // half
    {1.f, -0.01f, 1.f}, {1.f, -1.f, 1.f}, // half
    {-1.f, -0.01f, 1.f}, {-1.f, -1.f, 1.f} // half
yohjimane commented 6 months ago

@SkyLoaderr I just tested this out, and it seems to work! Any idea what a more permanent solution would look like?