OpenXRay / xray-16

Improved version of the X-Ray Engine, the game engine used in the world-famous S.T.A.L.K.E.R. game series by GSC Game World. Join OpenXRay! ;)
https://discord.gg/sjRMQwv
Other
2.9k stars 455 forks source link

Snag's box dupe #1655

Open Xottab-DUTY opened 2 months ago

Xottab-DUTY commented 2 months ago

Describe the bug It's possible to dupe the contents of Snag's box, asking Kardan to crack it and dropping the box mid-process.

To Reproduce Steps to reproduce the behavior: in the video.

Expected behavior To be determined.

Screenshots, videos https://youtube.com/shorts/g-cAD2RAR_I

Xottab-DUTY commented 2 months ago

@Decane, @SurDno, did you know about this? Do you have any ideas on fix, maybe?

SurDno commented 2 months ago

Easiest way is checking whether the player currently has a container in the functions for giving the items, but you’d have to separate Cardan related functions from Snag’s. This way even if somebody tries to abuse this, no items will be given if they don’t have a container.