search

OpenXRay / xray-16

Improved version of the X-Ray Engine, the game engine used in the world-famous S.T.A.L.K.E.R. game series by GSC Game World. Join OpenXRay! ;)
https://discord.gg/sjRMQwv
Other
3.06k stars 456 forks source link

Manjaro: quicksave is not loading #686

Closed TarasHots closed 3 years ago

TarasHots commented 4 years ago

Describe the bug Quicksave load is leading to game crash

To Reproduce Steps to reproduce the behavior:

  1. Open the game
  2. In Main menu go to load saved games
  3. Try to load test - quicksave.zip
  4. See that in the middle of the loading game will crash

Expected behavior Quicksave should be loaded and I can finally bring basic tools to Cardan! :dancers:

Desktop (please complete the following information):

Additional context openxray.log

TarasHots commented 4 years ago

Test cases with xr_map

xr_map - faulty quicksave - Skadovsk

ss_skadovsk_10_fps_11-25-20_21-24-25_(zaton) FPS - 10 saved game - skadowsk-10-fps - quicksave.zip

xr_map - new game - start location

ss_starting_11-25-20_19-48-45_(zaton) FPS - 17 saved game - start loc- quicksave.zip

xr_map - new game - Skadovsk

ss_skadovsk_17_fps_11-25-20_21-28-39_(zaton) FPS - 17, totally playable saved game is the same from previous test

xr_map - faulty quicksave - with Shoker's script

I put release_body_manager_noconsole.zip to .local/share/GSC Game World/S.T.A.L.K.E.R. - Call of Pripyat/gamedata When viewing something else, FPS is 20+ ss_shoker_10_fps_11-25-20_21-43-41_(zaton)

When viewing Skadovsk, FPS is 10 ss_shoker_20+_11-25-20_21-43-49_(zaton)

Test cases with xr_unordered_map

xr_unordered_map - faulty quicksave

Fails with attempt to index local 'actor' (a nil value) which is expected

xr_unordered_map - faulty quicksave - with Shoker's script

unordered_shoker FPS - 17, playable

I also tried late evening and morning. Morning has a little bit lower FPS, since there are many stalkers out there shoker_morning_1 shoker_morning_2

xr_unordered_map - new game - with Shoker's script

new_game_unordered Both at starting point and Skadovsk, all good and playable with 17+ FPS

Summary

New game is good both with xr_map or xr_unordered_map with 17 FPS Faulty quicksave has issues on Skadovsk only and looks like data structure used does not matter there

eagleivg commented 3 years ago

Исправлено в https://github.com/OpenXRay/xray-16/commit/edbaac6c3639077e89f4e568145489630c2ce41c