Closed dozylynx closed 8 years ago
The code LGTM. However, the branch you used has issues and the PR has conflicts that prevents merging (the slash in the branch name probably doesn't help either!).
Looking at your openxt repository, I noticed it is a fork of my fork of the original repository. I suggest you remove/rename it and fork the original repository directly (https://github.com/OpenXT/openxt).
Then it should be easy to branch, apply your changes and do a "proper" pull request.
Finally, we usually add a "signed-off" to our commits, see this page for more details: https://openxt.atlassian.net/wiki/display/DC/Commit+Message+Guidelines
Fixes OXT-494