windows: mkbuildmachine: add support for using a mirror

OpenXT / openxt

Base OpenXT build scripts

48 stars 39 forks source link

windows: mkbuildmachine: add support for using a mirror #126

Closed jean-edouard closed 8 years ago

jean-edouard commented 8 years ago

OXT-507

Signed-off-by: Jed lejosnej@ainfosec.com

rossphilipson commented 8 years ago

It is kind of confusing how you have the full URLs to the file and in addition the package (file) names in a separate list. It might be clearer if the URLs were the base part that the mirror overrides.

jean-edouard commented 8 years ago

I agree, but sometimes the name given to the downloaded file is not the same as the name in the URL, and I didn't want to mess with more than I had to... Maybe as a separate pull request?

rossphilipson commented 8 years ago

Oh well if that is the case then it is fine. I don't want to bust stuff just for something small like that. Disregard...

rossphilipson commented 8 years ago

Will merge soon...