OpenXT / openxt

Base OpenXT build scripts
48 stars 39 forks source link

build-scripts: add syncxt layer and misc fixes #186

Closed jean-edouard closed 8 years ago

jean-edouard commented 8 years ago

Signed-off-by: Jed lejosnej@ainfosec.com

dozylynx commented 8 years ago

Would you be willing to separate out the build script changes for layer support from the introduction of the syncxt layer?

I think there's a bit of design review or discussion might be helpful on the build script changes - JIRA could be a good place to do that. With these scripts there are a couple of different methods of getting git repos into the build - via git submodules or explicitly listing them in the build-scripts setup scripts - and we don't have support for layers expressing dependencies on other (external) OE layers they might use.

With the syncxt layer, it's very helpful to see a concrete example and all the pieces that need moving to make it work. I would suggest holding off on merging that until after next week's call to see what the decision ends up being on what layers belong together in a common repo and which ones should be their own repo, and how openxt layers / repos should be named.

Does the choice of '05' as the layer number in the filename indicate that the numbering scheme is going to end up being clunky to work with? (eg. only three layers fit cleanly between xenclient-oe and syncxt?)

jean-edouard commented 8 years ago

Like this? https://github.com/OpenXT/openxt/pull/187

'05' is completely random btw

dozylynx commented 8 years ago

@jean-edouard : Yes, #187 is better, thanks. I'll add further comment on that PR.