OpenXT / openxt

Base OpenXT build scripts
48 stars 39 forks source link

setup_build: Use bash shebang #374

Closed jandryuk closed 3 years ago

jandryuk commented 3 years ago

local git=${!git_var} is a bash-ism, so specify bash as the interpreter.

Signed-off-by: Jason Andryuk jandryuk@gmail.com

dozylynx commented 3 years ago

I'd like to look into whether there is an alternative option not requiring bash, since avoiding it helps on Devuan - will add a comment here when I've looked at the script shortly

jandryuk commented 3 years ago

Most scripts in this repo already require bash, so you have lots to do. This just corrects a clearly broken script. This may be one of the reasons why we have comments like # Use bash instead of dash for /bin/sh for setting up build environments.

dozylynx commented 3 years ago

Agreed, I think that is fair. It looks like that substitution line contracts quite a bit of stuff that would otherwise be done and your change is a fix to express what the script requires - thanks.

dozylynx commented 3 years ago

@eric-ch : ok to continue with your merge

eric-ch commented 3 years ago

Will merge soon :).