Closed jandryuk closed 3 years ago
I'd like to look into whether there is an alternative option not requiring bash, since avoiding it helps on Devuan - will add a comment here when I've looked at the script shortly
Most scripts in this repo already require bash, so you have lots to do. This just corrects a clearly broken script. This may be one of the reasons why we have comments like # Use bash instead of dash for /bin/sh
for setting up build environments.
Agreed, I think that is fair. It looks like that substitution line contracts quite a bit of stuff that would otherwise be done and your change is a fix to express what the script requires - thanks.
@eric-ch : ok to continue with your merge
Will merge soon :).
local git=${!git_var}
is a bash-ism, so specify bash as the interpreter.Signed-off-by: Jason Andryuk jandryuk@gmail.com