search

OpenXbox / smartglass-documentation

Documentation of the Xbox One SmartGlass protocol
https://openxbox.github.io/smartglass-documentation
34 stars 8 forks source link

Channel Start Request And Channel Stop need Ack #11

Open tuxBurner opened 3 years ago

tuxBurner commented 3 years ago

Hi @tuxuser ,

is it correct that http://openxbox.org/smartglass-documentation/message/#channel-start-request and http://openxbox.org/smartglass-documentation/message/#channel-stop

don't need ack ? In the code both use ack.

Greetings @tuxBurner

tuxuser commented 3 years ago

Checking that later, thx for now

FanLemon commented 3 years ago

Hi @tuxuser ,

is it correct that http://openxbox.org/smartglass-documentation/message/#channel-start-request and http://openxbox.org/smartglass-documentation/message/#channel-stop

don't need ack ? In the code both use ack.

Greetings @tuxBurner

Send Channel Start ----> Read Channel Start Response ----> Send Ack

tuxuser commented 3 years ago

Start channel indeed is defined as needing ack:

https://github.com/OpenXbox/xbox-smartglass-core-python/blob/e01a5413c788bbbbd62a631b170a789fe19d77dc/xbox/sg/factory.py#L293

Stop channel does not apparently, but also - never seen Stop channel message being sent in the wild:

https://github.com/OpenXbox/xbox-smartglass-core-python/blob/e01a5413c788bbbbd62a631b170a789fe19d77dc/xbox/sg/factory.py#L316