search

OpenXbox / xbox-webapi-python

A python library to authenticate with Xbox Live via your Microsoft Account and provides Xbox related Web-API.
https://pypi.python.org/pypi/xbox-webapi
MIT License
175 stars 44 forks source link

RequestSigner: MaxBodyBytes not used? #33

Closed Alexis-Bize closed 3 years ago

Alexis-Bize commented 3 years ago

Hey there, as NSAL services return a MaxBodyBytes property depending of the used Version from Policies, shouldn't it be used to truncate the body (if required) in the _hash method?

tuxuser commented 3 years ago

Absolutely correct. But as we neither have a parser for NSAL endpoints response nor is the RequestSigner actually utilized right now, it is not implemented yet.

PS: Related sources

NSAL https://github.com/blgrossMS-zz/xbox-live-api/blob/master/Source/System/auth/nsal.cpp https://github.com/blgrossMS-zz/xbox-live-api/blob/master/Source/System/auth/nsal.h https://github.com/blgrossMS-zz/xbox-live-api/blob/master/Source/System/auth/nsal_endpoint.cpp https://github.com/blgrossMS-zz/xbox-live-api/blob/master/Source/System/auth/nsal_endpoint.h

Signature policy https://github.com/blgrossMS-zz/xbox-live-api/blob/master/Source/System/auth/signature_policy.cpp https://github.com/blgrossMS-zz/xbox-live-api/blob/master/Source/System/auth/signature_policy.h

Alexis-Bize commented 3 years ago

Oh, great then. Looking forward to it!