search

OpenXiangShan / GEM5

BSD 3-Clause "New" or "Revised" License
54 stars 21 forks source link

Forget to clear the `_ever_prefetched` flag in the CacheBlk::invalidate() function #44

Closed Kepontry closed 2 weeks ago

Kepontry commented 8 months ago

The function clearPrefetched() doesn't clear the _ever_prefetched flag. It seems that here we need a clearEverPrefetched() like function. When that is applied, there is a slight change in scores(<0.02). https://github.com/OpenXiangShan/GEM5/blob/6a85ffb479c8c1ecff432ddd5801216b4e829580/src/mem/cache/cache_blk.hh#L205-L209

shinezyy commented 7 months ago

We will evaluate its impact on performance.

tastynoob commented 2 weeks ago

Fixed, use clearAllPrefetched()