search

OpenXiangShan / XiangShan

Open-source high-performance RISC-V processor
Other
4.45k stars 619 forks source link

difftest: check load only when isAmo or isLoad and skip MMIO #3026

Closed klin02 closed 3 weeks ago

klin02 commented 1 month ago

Previous we submit loadEvent for all committed instructions. According to cpp code, we only check load when isAmo and isLoad. And MMIO will be skipped, no need to check REF and GoldenMem.

When some loadEvent are dropped to speed up difftest, this change fix legacy impact of loadEvent unprocessed before.

klin02 commented 4 weeks ago

Error of CI results from legacy impact of previous LoadEvent. We have fix this in https://github.com/OpenXiangShan/difftest/pull/389. Corresponding logic at https://github.com/OpenXiangShan/difftest/blob/2d4919fc90d8c0452f0476e2148d12a6ff38b5be/src/test/csrc/difftest/difftest.cpp#L509

And we also bump difftest.

XiangShanRobot commented 3 weeks ago
[Generated by IPC robot] commit: fb85adc33e1126e840b5cdc6f909d3898af6b1c2 commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
fb85adc 1.815 0.448 2.060 1.182 2.953 2.504 2.291 0.930 1.403 1.319 3.426 2.660 2.397 2.940
master branch: commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
31fae68 1.815 0.448 2.060 1.182 2.953 2.504 2.291 0.930 1.403 1.319 3.426 2.660 2.397 2.940
071c63e 1.815 0.448 2.060 1.182 2.953 2.504 2.291 0.930 1.403 1.319 3.426 2.660 2.397 2.940
6b742a1 1.821 0.448 2.054 1.173 2.950 2.500 2.291 0.923 1.376 1.265 3.448 2.667 2.398 2.940
dc30dd9 1.821 0.448 2.054 1.173 2.950 2.500 2.291 0.923 1.376 1.265 3.448 2.667 2.398 2.940
cd467f7 1.821 0.448 2.054 1.173 2.950 2.500 2.291 0.923 1.376 1.265 3.448 2.667 2.398 2.940
75b44a5 1.821 0.448 2.054 1.173 2.950 2.500 2.291 0.923 1.376 1.265 3.448 2.667 2.398 2.940
321866f 1.821 0.448 2.054 1.173 2.950 2.500 2.291 0.924 1.376 1.265 3.448 2.667 2.398 2.940
082b30d 1.821 0.448 2.054 1.173 2.950 2.500 2.291 0.923 1.376 1.265 3.448 2.667 2.398 2.940
0e28018 1.823 0.448 2.054 1.172 2.950 2.500 2.292 0.923 1.376 1.265 3.449 2.656 2.398 2.943
df7130a 1.823 0.448 2.054 1.172 2.950 2.500 2.292 0.923 1.376 1.265 3.449 2.656 2.398 2.943