OpenXiangShan / XiangShan

Open-source high-performance RISC-V processor
Other
4.45k stars 618 forks source link

DCache: Fix x-prop caused by l2_error #3075

Closed bosscharlie closed 1 week ago

bosscharlie commented 2 weeks ago

Add valid mux for s2_l2_error to fix X propagation.

XiangShanRobot commented 2 weeks ago
[Generated by IPC robot] commit: 27e14d35863dd5f4e0ad44b5005833625c1f9409 commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
27e14d3 1.808 0.447 2.043 1.187 2.938 2.508 2.197 0.921 1.369 1.441 3.454 2.658 2.399 2.932
master branch: commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
26c1abd 0.448 2.039 2.197 0.930 1.378 2.669 2.932
fd3aa05 2.040 1.187 2.936 2.508 0.930 1.378 1.441 3.428 2.932
1b0de92 1.808 0.447 2.043 1.187 2.938 2.508 2.197 0.921 1.369 1.441 3.454 2.658 2.399 2.932
d8a998b 1.808 0.447 2.043 1.187 2.938 2.508 2.197 0.921 1.369 1.441 3.454 2.658 2.399 2.932
ee8d1f1 1.808 0.447 2.043 1.187 2.938 2.508 2.197 0.921 1.369 1.441 3.454 2.658 2.399 2.932
fcec058 1.808 0.447 2.043 1.187 2.938 2.508 2.197 0.921 1.369 1.441 3.454 2.658 2.399 2.932
0fbf39a 1.808 0.447 2.043 1.187 2.938 2.508 2.197 0.921 1.369 1.441 3.454 2.658 2.399 2.932
Tang-Haojin commented 1 week ago

Seems that there is no xprop bug related to l2_error. I would like close this PR now. If there is any further problem, feel free to reopen this or file a new PR.