search

OpenXiangShan / difftest

Modern co-simulation framework for RISC-V CPUs
Mulan Permissive Software License, Version 2
118 stars 66 forks source link

difftest: automatically set the overwrite-size of new gpct #460

Closed xiaokamikami closed 2 months ago

xiaokamikami commented 2 months ago

New versions of gcpt allow you to set oversize automatically. if you don't specify size manually, gcpt will look for an oversize flag，on vcs/palldium using --set_overwrite_autoset enable auto set oversize，on emu using --overwrite-auto

xiaokamikami commented 2 months ago

I think mixing in the dirty code for checkpoints is a bad idea. I suggest rethinking how the support for checkpoints should be implemented.

However, I'm ok to approve it if you can rearrange the multiple printf's. I don't understand why you need so many printf's

I think mixing in the dirty code for checkpoints is a bad idea. I suggest rethinking how the support for checkpoints should be implemented.

However, I'm ok to approve it if you can rearrange the multiple printf's. I don't understand why you need so many printf's

I have the code to print gcpt siz elsewhere, so I'm going to remove the printf here

xiaokamikami commented 2 months ago

Look good to me now.

Only VCS supports this? Do we need to add support for verilator?

I've also added support in case someone needs to run a new checkpoint on emu