OpenZWave / Zwave2Mqtt

Fully configurable Zwave to MQTT gateway and Control Panel using NodeJS and Vue
MIT License
352 stars 93 forks source link

GE/enbrighten switches[question] #804

Open benchdog93 opened 3 years ago

benchdog93 commented 3 years ago

When adding name in control panel switches become disabled, remove the name in control panel and the are active again. Dimmer does not retain its position and needs multiple clicks. The way I would expect the dimmer to work would be a single click on, set brightness, a single click off, and for the brightness level to be maintained. At least that how they worked with past applications I have used.

Not sure how to fix this

I am using: Z-Wave to MQTT Current version: 0.8.1 (changelog)

Switches I am having an issue with: 14292 In-Wall Smart Toggle Switch (GE (Jasco Products)) 14295 In-Wall Smart Toggle Dimmer (GE (Jasco Products))

Thank you for your help.

robertsLando commented 3 years ago

When adding name in control panel switches become disabled

Sorry but I don't understand what you mean, are you speaking about home assistant switches or switches in z2m control panel?

benchdog93 commented 3 years ago

I am talking about z2m control panel. I can rename them in HA fine but that does not show their name in the z2m control panel. I have the 14288 Duplex Receptacles (GE (Jasco Products)) that allow me to add a name in the z2m control panel and work as expected. I have several of these receptacles and switches to add and it would make it easier to manage having their name and location in the z2m control panel.

Thank you

robertsLando commented 3 years ago

@benchdog93 Could you show me a gif that shows this ?

benchdog93 commented 3 years ago

z2m_control_panel

Attached is the screen shot of my z2m control panel. I think this is what you are asking for.

benchdog93 commented 3 years ago

mqtt

This is what it looks like in mqtt

benchdog93 commented 3 years ago

devive_in_mqtt

This is where I rename it for HA

robertsLando commented 3 years ago

@benchdog93 When you rename it it looses the reference in zwave2mqtt, you should rename it on zwave2mqtt

benchdog93 commented 3 years ago

This is my issue. When I rename swithes, I've listed above, in zwave2mqtt I can not operate the switch in Home Assistant, When clicking on the switches to change state it changes for an instant then returns back and no longer operates. It is the same with both types of switches listed. Also when I remove the name in zwave2mqtt the switches operate in HA. I can rename these switches in mqtt but this only changes their name in HA. I need them to be renamed in zwave2mqtt to manage my network and to work as expected.

Also, when the dimmer switch is functional (not renamed in zwave2mqtt) it does not work as expected. Dimmer does not retain its position (brightness level) and needs multiple clicks. The way I would expect the dimmer to work would be a single click on, set brightness, a single click off, and for the brightness level to be maintained. At least that how they worked with past applications I have used. The way it operates now is click on set the level for brightness then the first click turns off the light and a second click is required to return the switch to the off state in HA.

New to this and maybe I am doing sonething wrong but when I installed the receptacle and renamed in zwave2mqtt all worked fine.

Let me know if you need more.

Thank you

z2m rename

robertsLando commented 3 years ago

@benchdog93 After renaming themyou hae to press on Rediscover node because the name is part of the topic

robertsLando commented 3 years ago

Also you should enable retain in mqtt settings. (do NOT enable retain discovery, that's another thing)

benchdog93 commented 3 years ago

I am away until Monday and see if these changes work.

Thank you

benchdog93 commented 3 years ago

I was able to work on it tonight. Does not work still. I had already tried Rediscover Node in the past.

robertsLando commented 3 years ago

Could you show me your settings?

benchdog93 commented 3 years ago

Screen shots of my settings

zwave mqtt gateway

robertsLando commented 3 years ago

@benchdog93 From a settings side everything seems good. As I can see you are using node names in nodes so when you chage them also topics of that node will change and you will need to rediscover that specific node to update discovery tepmplates with updated topics. I think there should be a user error somewhere in the process because I cannot see anythign wrong here

benchdog93 commented 3 years ago

I will need to figure it out I don't see any user errors. When I have a day to dedicate to it I will and let you know.

Did you look at the dimmer switch issue I am seeing? I have not look at that for a while.

robertsLando commented 3 years ago

Yes I looked at it but can't figure out what's wrong there, I'm sorry :( let me know if you find something that I can help

teknomar7 commented 3 years ago

I was never able to get my GE dimmer / motion sensor switches to work with the default configuration in zwave2mqtt. The regular switches work fine, but for dimmer / motion I had to disable auto discovery in zwave2mqtt for those and define them manually in the HA config file. This is what my configuration looks like for a dimmer...

light:
  - platform: mqtt
    name: "Dining Room Table"
    command_topic: "zwave2mqtt/DiningRoom/Table/38/1/0/set"
    brightness_command_topic: "zwave2mqtt/DiningRoom/Table/38/1/0/set"
    brightness_scale: '99'
    brightness_state_topic: "zwave2mqtt/DiningRoom/Table/38/1/0"
    brightness_value_template: "{{ value_json['value'] }}"
    on_command_type: "brightness"
    payload_on: 99
    payload_off: 0
    device:
      identifiers:
        - zwave2mqtt_0xdfa4123a_node6
      manufacturer: GE (Jasco Products)
      model: 46203 In-Wall Smart Dimmer (0x3235)
      name: DiningRoom-Table
      sw_version: Unknown
    unique_id: zwave2mqtt_0xdfa4123a_6-38-1-0
robertsLando commented 3 years ago

@teknomar7 What's the difference from the original discover sent from z2m?

teknomar7 commented 3 years ago

This is what it looks like for the same switch for the light_dimmer id in the json within zwave2mqtt (assume this is what you are looking for):

{
  "type": "light",
  "object_id": "dimmer",
  "discovery_payload": {
    "schema": "template",
    "brightness_template": "{{ (value_json.value / 99 * 255) | round(0) }}",
    "state_topic": "zwave2mqtt/DiningRoom/Table/38/1/0",
    "state_template": "{{ \"off\" if value_json.value == 0 else \"on\" }}",
    "command_topic": "zwave2mqtt/DiningRoom/Table/38/1/0/set",
    "command_on_template": "{{ ((brightness / 255 * 99) | round(0)) if brightness is defined else 255 }}",
    "command_off_template": "0",
    "device": {
      "identifiers": [
        "zwave2mqtt_0xdfa4123a_node6"
      ],
      "manufacturer": "GE (Jasco Products)",
      "model": "46203 In-Wall Smart Dimmer (0x3235)",
      "name": "DiningRoom-Table",
      "sw_version": "5.54"
    },
    "name": "DiningRoom-Table_dimmer",
    "unique_id": "zwave2mqtt_0xdfa4123a_6-38-1-0"
  },
  "discoveryTopic": "light/DiningRoom-Table/dimmer/config",
  "values": [
    "38-1-0"
  ],
  "persistent": true,
  "ignoreDiscovery": true,
  "id": "light_dimmer"
}
teknomar7 commented 3 years ago

I think the state topic is what causes problems. At least when I tried to define state topic in HA manually, I had issues. Eliminating that was what solved my problem if I recall. It's been awhile since I had to figure this out and I just cloned the solution for all the dimmers and motion sensitive GE switches.

robertsLando commented 3 years ago

@teknomar7 Maybe this has been caused by an hass update? Because AFAIK light dimmers were working

teknomar7 commented 3 years ago

This has been like this since I installed these switches at least few months back (4+ months if I had to guess). I don't know if this applies to all dimmers or just the GE ones. Also, I have not tried to auto-rediscover these to see if the problem was corrected, but sounds like it isn't if the person who opened the issue is having similar behavior.

robertsLando commented 3 years ago
{
  "type": "light",
  "object_id": "dimmer",
  "discovery_payload": {
    "schema": "template",
    "command_topic": "zwave2mqtt/DiningRoom/Table/38/1/0/set"
    "brightness_command_topic": "zwave2mqtt/DiningRoom/Table/38/1/0/set"
    "brightness_scale": '99'
    "brightness_state_topic": "zwave2mqtt/DiningRoom/Table/38/1/0"
    "brightness_value_template": "{{ value_json.value }}"
    "on_command_type": "brightness"
    "device": {
      "identifiers": [
        "zwave2mqtt_0xdfa4123a_node6"
      ],
      "manufacturer": "GE (Jasco Products)",
      "model": "46203 In-Wall Smart Dimmer (0x3235)",
      "name": "DiningRoom-Table",
      "sw_version": "5.54"
    },
    "name": "DiningRoom-Table_dimmer",
    "unique_id": "zwave2mqtt_0xdfa4123a_6-38-1-0"
  },
  "discoveryTopic": "light/DiningRoom-Table/dimmer/config",
  "values": [
    "38-1-0"
  ],
  "persistent": true,
  "ignoreDiscovery": true,
  "id": "light_dimmer"
}

@teknomar7 What if you use this?

teknomar7 commented 3 years ago

I never tried fixing it from the zwave2mqtt side, but maybe I'll try that one day. Kind of taking the "don't fix it if it ain't broken" approach these days. But perhaps I will give this a try when I am feeling like messing with stuff again. Thanks!

robertsLando commented 3 years ago

But perhaps I will give this a try when I am feeling like messing with stuff again. Thanks!

Let me know! It could be that something has change and that is the correct template to use for lights :) If so I can submit a PR to automatically use that

Anyway keep an eye to the future of z2m: https://github.com/zwave-js/zwavejs2mqtt