OpenZWave / Zwave2Mqtt

Fully configurable Zwave to MQTT gateway and Control Panel using NodeJS and Vue
MIT License
354 stars 93 forks source link

Mesh not drawn correctly when removed node is part of mesh [bug] #895

Closed ratsputin closed 3 years ago

ratsputin commented 3 years ago

Version

Build/Run method

Zwave2Mqtt version: Latest Openzwave Version: 1.6.1789

Describe the bug A node that was previously at address 18 (AEON Labs ZW095 Home Energy Meter Gen5), was removed and is now at 27 is still showing as a neighbor on five nodes at its old address. Healing the network nor forcing the nodes in question to rebuild their neighbor list has resolved this issue.

Unfortunately, this breaks the Network Graph function badly resulting in random behavior.

To Reproduce I don't know that this is a common behavior but now that my network is in this state, the Network Graph always provides random results.

Expected behavior Unknown/removed nodes still reported as neighbors in the Z-Wave network topology should be mapped appropriately in the network mesh and labeled as "Unknown" or "Removed" as appropriate.

Additional context Add any other context about the problem here. Topology reported from OZWCP:

topo: node=1 6,7,8,9,10,12,15,25,27,30,31,32,33
topo: node=6 1,8,9,12,15,18,26,27,33
topo: node=7 1,8,9,10,25
topo: node=8 1,6,7,9,10,12,15,18,25,26,27
topo: node=9 1,6,7,8,10,12,15,25,26,27,30,31,32
topo: node=10 1,7,8,9,12,15,25
topo: node=12 1,6,8,9,10,15,18,25,27,33
topo: node=15 1,6,8,9,10,12,18,25,26,27,33
topo: node=24 9,25,30,31
topo: node=25 1,7,8,9,10,12,15,18,24,27,28,29,30,31,33
topo: node=26 6,8,9,15,27,33
topo: node=27 1,6,8,9,12,15,25,26,32,33
topo: node=28 25
topo: node=29 25,30
topo: node=30 1,9,24,25,29,31,32
topo: node=31 1,9,24,25,30,32
topo: node=32 1,9,27,30,31
topo: node=33 1,6,12,15,25,26,27

Note that 18 shows up as a neighbor to 6, 8, 12, 15, and 25 but not as an active node in the topology. I realize this may be an edge case; however, I've tried factory-resetting the node in question with no success. Presumably, this is a bug in the particular device's firmware. It appears my only alternative is to rebuild my network from scratch. I have to assume that if this has happened to me it likely has happened to someone else as well, though.

robertsLando commented 3 years ago

Switch to https://github.com/zwave-js/zwavejs2mqtt

ratsputin commented 3 years ago

Are there any instructions on how to migrate from zwave2mqtt and setup zwavejs2mqtt? I have no interest in running under docker.

robertsLando commented 3 years ago

https://zwave-js.github.io/zwavejs2mqtt/#/guide/migrating

ratsputin commented 3 years ago

Thank you very much, sir. Your effort on this is greatly appreciated. Without your hard work, I'd be stuck on SmartThings.