search

OpenZWave / node-openzwave-shared

OpenZWave addon for Node.js (all versions) including management and security functions
Other
199 stars 113 forks source link

include mismatch in openzwave.hpp and openzwave home folder structure #222

Closed emretapci closed 6 years ago

emretapci commented 6 years ago

The script in binding.gyp file assigns ...\AppData\Local\OpenZWave to variable OZW_HOME and include directory is therefore ...\AppData\Local\OpenZWave\include.

But in node-openzwave-shared\src\openzwave.hpp file, openzwave include references are like #include "openzwave/Manager.h". So, node-gyp rebuild cannot find the include files.

sogaani commented 6 years ago

hi @emretapci.

I met same issue with windows. And I made pull request #219 to fix it.

@ekarak Can you review it?

Thanks.

emretapci commented 6 years ago

I think the better solution is to remove openzwave/ prefixes in openzwave.hpp file #include directives.

#include "Manager.h" #include "openzwave/Driver.h" #include "openzwave/Node.h" #include "openzwave/Notification.h" #include "openzwave/Options.h" #include "openzwave/value_classes/Value.h"

sogaani commented 6 years ago

@emretapci You are right. I see binding.gyp again. On Linux and Mac, binding.gyp add "**/include/openzwave/" to include path.

I delete my pull request.

Apollon77 commented 6 years ago

Is anyone able to continue here? A version buildable on windows would be awesome!!

ekarak commented 6 years ago

ok I've just pushed a new branch ( bugfix/issue#222-inclusion-paths ) that removes the paths from the #include stanzas, I'm now trying to build it on Appveyor. Apologies for the delay, I have no Windows dev environment.

ekarak commented 6 years ago

Version 1.4.3 just released. This includes the fix in #222 and adds Appveyor CI support for Windows builds.