OpenZWave / node-openzwave-shared

OpenZWave addon for Node.js (all versions) including management and security functions
Other
199 stars 113 forks source link

Bug: addSceneValue not working as expected #266

Closed robertsLando closed 5 years ago

robertsLando commented 5 years ago

There is no support in addSceneValue for 'list' type and the 'decimal' type doesn't works

(BUG ---> 'SceneGetValueAsString' should be 'SceneGetValueListSelection') https://github.com/OpenZWave/node-openzwave-shared/blob/master/src/utils.cc#L200

https://github.com/OpenZWave/node-openzwave-shared/blob/master/src/utils.cc#L200

but OpenZwaveManager has them:

https://github.com/OpenZWave/open-zwave/blob/master/dotnet/src/ZWManager.h#L2043

https://github.com/OpenZWave/open-zwave/blob/master/dotnet/src/ZWManager.h#L2083

robertsLando commented 5 years ago

@ekarak this is not really closed as decimal values in scenes are not correctly sent yet. I'm not really good with C++ so maybe you can easily fix it, I think it is a parsing issue but can't find the way to fix it. Thanks