segmentation fault with release 1.5.1

nouknouk commented 5 years ago

I get segfaults with a fresh new install (without ozwcache) on my network composed of around 90 nodes.

What is observed for the moment (using the test2.js script).

segfault never raises at start, rather after 5 minutes, when the scan should be (almost ?) complete.
I reproduce when I run test2.js with 1.5.1 on a fresh install ( = no ozwcache file present)
It seems I don't reproduce with 1.5.0 with a 'fresh install' (99%, but not 100% sure for this one ; at least it seems far less frequent).
It seems I don't reproduce with 1.5.1 if I keep ozwcache file which has been generated before by 1.5.0

I didn't saw that much commits between 1.5.0 & 1.5.1, and some of them event replaced sprintf with snprintf (on purpose ?).

I'm investigating a bit, but without a trace, it's harder => what kind of tool should i use to have any chance to get a decent trace to spot the root cause of the segfault ?

Thanks in advance.

btw:

Linux nouknouk 4.9.0-8-amd64 #1 SMP Debian 4.9.130-2 (2018-10-27) x86_64 GNU/Linux
OpenZWave 1.6.770
node v12.4.0
npm 6.9.0

nouknouk commented 5 years ago

EDIT: it seems i reproduce too the segfault with 1.5.0

2 log files from start until before the segfault happens:

nouknouk commented 5 years ago

my bad ; it seems the segfault is already solved with the latest commits in the master branch (and so, probably since the last conversions of sprintf into snprintf)

Maybe, to avoid similar issues to other users using the npm package, a new release on npm would be welcome ?

OpenZWave / node-openzwave-shared

segmentation fault with release 1.5.1 #309