search

OpenZWave / node-openzwave-shared

OpenZWave addon for Node.js (all versions) including management and security functions
Other
199 stars 113 forks source link

Revert breaking change value type list, #316 #317

Closed robertsLando closed 5 years ago

ekarak commented 5 years ago

apologies for that. Maybe we need an API review for such changes in the future. For the record, this was requested in https://github.com/OpenZWave/node-openzwave-shared/pull/259/commits/dad8c1af226039e4a8e36b00502bbe1edd65e526

robertsLando commented 5 years ago

Yep there should be some test suites to make thats sure, unfortunately I’m not that good with tests also my repos need tests, so I can’t help in this :( maybe try to open an issue an flag it with “help wanted” label

On 28 Jun 2019, at 19:59, Elias Karakoulakis notifications@github.com wrote:

apologies for that. Maybe we need an API review for such changes in the future. For the record, this was requested in dad8c1a

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.