search

OpenZWave / node-openzwave-shared

OpenZWave addon for Node.js (all versions) including management and security functions
Other
199 stars 113 forks source link

Broken build 1.5.X #320

Closed robertsLando closed 5 years ago

robertsLando commented 5 years ago

Broken build when trying to install openzwave-shared v 1.5.3

./src/openzwave-groups.cc: In static member function ‘static Nan::NAN_METHOD_RETURN_TYPE OZW::OZW::IsGroupMultiInstance(Nan::NAN_METHOD_ARGS_TYPE)’:
../src/openzwave-groups.cc:175:37: error: ‘class OpenZWave::Manager’ has no member named ‘IsMultiInstance’; did you mean ‘s_instance’?
   OZWManagerAssign(isMultiInstance, IsMultiInstance, homeid, nodeid, groupidx);
                                     ^
../src/utils.hpp:36:43: note: in definition of macro ‘OZWManagerAssign’
      VALUE = OpenZWave::Manager::Get() -> METHOD ( __VA_ARGS__ ); \
                                           ^~~~~~
robertsLando commented 5 years ago

Ignore my PR, that doesn't fix the problem was just a thought

robertsLando commented 5 years ago

@ekarak please take a look into this it is still bugged in 1.5.4 version!!

thucar commented 5 years ago

How do I apply this fix?

robertsLando commented 5 years ago

Just check the pr here

Daniel

On 5 Jul 2019, at 13:09, thucar notifications@github.com wrote:

How do I apply this fix?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

robertsLando commented 5 years ago

@ekarak version 1.5.5 is still bugged... 

../src/openzwave-groups.cc:175:37: error: ‘class OpenZWave::Manager’ has no member named ‘IsMultiInstance’; did you mean ‘s_instance’?
   OZWManagerAssign(isMultiInstance, IsMultiInstance, homeid, nodeid, groupidx);
                                     ^
../src/utils.hpp:36:43: note: in definition of macro ‘OZWManagerAssign’
      VALUE = OpenZWave::Manager::Get() -> METHOD ( __VA_ARGS__ ); \
                                           ^~~~~~
openzwave_shared.target.mk:138: recipe for target 'Release/obj.target/openzwave_shared/src/openzwave-groups.o' failed
make: *** [Release/obj.target/openzwave_shared/src/openzwave-groups.o] Error 1