search

OpenZWave / node-openzwave-shared

OpenZWave addon for Node.js (all versions) including management and security functions
Other
199 stars 113 forks source link

[fix] Broken build from version 1.5.3 to 1.5.5 #327

Closed robertsLando closed 5 years ago

robertsLando commented 5 years ago

320

robertsLando commented 5 years ago

@ekarak Please merge this one and release a new version once you can... I want to release a new stable version of Zwave2MQTT 1.3.0. I have successfully tested it and it compiles now

milosjovac commented 5 years ago

We tried this patch for fixing the issue https://github.com/OpenZWave/node-openzwave-shared/issues/322 and it works.

Can you please share which sub-dependency made problems with a build?

robertsLando commented 5 years ago

@milosjovac There were 2 problems: first one it was using ifdef instead of if in C++ preprocessing. Than there was a problem with enum class. Check the tab here named "Files changed" for more info

milosjovac commented 5 years ago

@robertsLando tnx for the info. I was referring more to the reason of openzwave-shared not being buildable since ~2 weeks ago. Even with older versions it doesn't build at the moment (ex. 1.5.0), so it has to be that some of the dependencies have been changed. Do you know which one?

robertsLando commented 5 years ago

@milosjovac There was no problem with any deps, the problems were many, the first I had found was a typo on groups, than there was problems with bindings.gyp caused by ldconfig command than this one I think is the last one. Everything was caused by the updates to support OZW 1.6 starting from version 1.5

justinwalsh commented 5 years ago

This fixed work for me! Confirmed builds are back and working on raspbian.

cmanou commented 5 years ago

This worked for me as well would be good to get a NPM release out with the fix

ekarak commented 5 years ago

version 1.5.6 just released on NPM