OPENZWAVE16_DEPRECATED gyp flag broken install

OpenZWave / node-openzwave-shared

OpenZWave addon for Node.js (all versions) including management and security functions

Other

199 stars 113 forks source link

OPENZWAVE16_DEPRECATED gyp flag broken install #355

Closed robertsLando closed 4 years ago

robertsLando commented 4 years ago

@ekarak There are several bug on openzwave-scenes.cpp and utils.hpp files inside IFDEF OPENZWAVE16_DEPRECATED blocks, I have tried to fix them but unfortunally I'm stucked, I need your help

I'm also unable to install the module with the flag OPENZWAVE16_DEPRECATED to enable methods like writeConfig. I have tryed with npm install --OPNEZWAVE16_DEPRECATED=1 but it doesn't work

robertsLando commented 4 years ago

@ekarak I think you made a wrong find/replace on openzwave-scenes.cpp that has broke many things in this commit: 065c9178ec1792268b7fb3592025693a9512e21f

ekarak commented 4 years ago

are we ok to close this down @robertsLando ?

robertsLando commented 4 years ago

Sure

On 23 Mar 2020, at 07:27, Elias Karakoulakis notifications@github.com wrote:

are we ok to close this down @robertsLando ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.