search

OpenZWave / node-openzwave-shared

OpenZWave addon for Node.js (all versions) including management and security functions
Other
199 stars 113 forks source link

Fix build issue #356 #359

Closed piec closed 4 years ago

piec commented 4 years ago

Hi,

This patch uses a portable Nan helper method instead of using v8::Object::Set directly in order to fix the build in my setup, see #356 https://github.com/nodejs/nan/blob/master/doc/maybe_types.md#nanset

(it's the first time I do native nodejs dev so not sure this is 100% correct)

Best regards, Pierre

robertsLando commented 4 years ago

@piec What issue does this fix?

piec commented 4 years ago

@robertsLando This one https://github.com/OpenZWave/node-openzwave-shared/issues/356

robertsLando commented 4 years ago

lgtm