Closed piec closed 4 years ago
Hi,
This patch uses a portable Nan helper method instead of using v8::Object::Set directly in order to fix the build in my setup, see #356 https://github.com/nodejs/nan/blob/master/doc/maybe_types.md#nanset
(it's the first time I do native nodejs dev so not sure this is 100% correct)
Best regards, Pierre
@piec What issue does this fix?
@robertsLando This one https://github.com/OpenZWave/node-openzwave-shared/issues/356
lgtm
Hi,
This patch uses a portable Nan helper method instead of using v8::Object::Set directly in order to fix the build in my setup, see #356 https://github.com/nodejs/nan/blob/master/doc/maybe_types.md#nanset
(it's the first time I do native nodejs dev so not sure this is 100% correct)
Best regards, Pierre