OpenZWave / node-openzwave-shared

OpenZWave addon for Node.js (all versions) including management and security functions
Other
198 stars 113 forks source link

Changes to make the windows build compatible with Node 12. #364

Closed trankin closed 4 years ago

trankin commented 4 years ago

I was not able to successfully use this library with Node 12 on windows, getting several build errors on the openzwave.lib compilation. I slogged through it a bit today and found some current alternative tools to use and have tested that this works successfully for me and the openzwave.lib is still compatible with my current projects.

replaced wrench with fs-extra because it is long deprecated. replaced unzip with unzipper because unzip was not compat.

rewrote some of the file system directory lookups to be compatible with the original intent but using fs-extra.. or a custom recursive folder list. added the package.json file to the temp folder for compat.

robertsLando commented 4 years ago

LGTM