search

OpenZWave / node-openzwave-shared

OpenZWave addon for Node.js (all versions) including management and security functions
Other
199 stars 113 forks source link

Adding in Github Actions for CI. #381

Closed trankin closed 4 years ago

trankin commented 4 years ago

Linux seems fine, Windows was failing on node_js versions 8.x, 10.x and 11.x. I've removed those in this pull request as I'm not sure if the problem is on the github side or the build code in the repository.

robertsLando commented 4 years ago

windows build is failing because you haven't installed OZW

trankin commented 4 years ago

windows build is failing because you haven't installed OZW

I believe part of the windows node-gyp build is to is to build and install OZW correct? It's working on node 12.

robertsLando commented 4 years ago

I believe part of the windows node-gyp build is to is to build and install OZW correct

You are right (never used it under windows but by checking the code it seems to do it automatically)

So I think something fails in the install process, can you show me the error?

trankin commented 4 years ago

I believe part of the windows node-gyp build is to is to build and install OZW correct

You are right (never used it under windows but by checking the code it seems to do it automatically)

So I think something fails in the install process, can you show me the error?

Are you able to see this? https://github.com/trankin/node-openzwave-shared/runs/750522182?check_suite_focus=true

robertsLando commented 4 years ago

@trankin

Error: spawn C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\15.0\Bin\MSBuild.exe ENOENT

trankin commented 4 years ago

Likely related to this: https://github.com/actions/virtual-environments/issues/68 We may need VS2017 for older versions of nodejs. I won't be able to dig in and review this further for a few days, and can't guarantee that I'll come up with a solve in short order (not to say that it's a hard problem to solve, I have some digging to do as this I'm still getting familiar with github actions), you might consider merging this pull request and leave appveyor running until it's resolved to get older versions running in github actions, or I can remove the windows side of the build in github actions altogether until it's resolved. Let me know how you'd like to see this move forward.

robertsLando commented 4 years ago

@trankin Don't worry thanks for your collaboration I will dig into this next days

trankin commented 4 years ago

I've confirmed that the problem is in the github actions runner. windows-latest fails for node_js versions 8.x, 10.x and 11.x, however windows-2016 builds successfully for 8.x, 10.x and 11.x. I've updated the action to use windows-2016 for 8.x, 10.x and 11.x and windows-latest for 12.x.