Closed poudenes closed 5 years ago
Thank you for reporting this. You can either wait for someone to pick up your request... Or you can try to open a "pull request" yourself. Detailed intsructions on those config files are here
https://github.com/OpenZWave/open-zwave/wiki/Adding-Devices
I had a quick look and because "type" and "id" do not change, I see no reason to introduce a new name for the config file, just edit the old one. Maybe I am missing something. Any reason to call it "pd02ze"?
Because the old one als use same xml file. If you check the manufacturer xml file you see that 2 product id's use same xml file.
Thank you for clarifying that. I know the situation with the Neo Motion sensor is a bit "messy". There is an older version and a newer (they look different) with different IDs but then the new one exists in two variants, with or without temperature reporting. I am not sure but we would probably need to take into account the firmware version to differentiate. I own the second version with temp sensor. I noticed many documents float on the internet, all having slightly different parameters. Do you happen to know if they add parameters only, depending on revision? Then one config file could serve different variants. If they change the meaning or size of parameters then... we have a problem...
Oh I don't know.... I also have the newer version with temperature.
Okay, as I suspected, we have a problem... There is indeed a "V2 with temperature sensor" and a "V2 without a temperature sensor" (older). Based on the current entries both devices use the same id="108d" and type="0003" because they have different parameters, so OZW cannot see the difference.
The one without temp has p 10 = "Blink enable" and so the current config file is correct for all older devices without temp reporting.
As soon as they added temp, p 10 became "temperature diff reporting".
I have to think about it but there might be a solution: I could describe parameter 10 as "temperature diff reporting if the device supports temp and blink enable if it does not".
This device has no entry in the Alliance database https://products.z-wavealliance.org
And I cannot find a canonical source for the manual(s) either... This makes it more difficult to make (good) decisions.
Because the old one als use same xml file. If you check the manufacturer xml file you see that 2 product id's use same xml file.
I've checked and I don't think we are looking at the same config/manufacturer_specific.xml file... the "master" version only has one reference to "pd02z.xml". Can you double check? BTW it is not unusual to have two different id/type pairs to point to the same xml file, they might be regional variants (frequencies) or hardware revisions using the same set of config options.
I've checked and I don't think we are looking at the same config/manufacturer_specific.xml file... the "master" version only has one reference to "pd02z.xml". Can you double check? BTW it is not unusual to have two different id/type pairs to point to the same xml file, they might be regional variants (frequencies) or hardware revisions using the same set of config options.
Youre right:
There is 1 line for the pd02z.xml for ID 108d
Here I have 1 old one and 6 new versions. I include the old one with old XML. After that change the line so it refer to new XML file and reboot my "Domoticz" and then add the new versions with new XML
For me problem was solved. But I can imagine when people have both versions and don't have the knowledge their stuck.
First reason to give the XML new name was because of this link:
https://products.z-wavealliance.org/products/1920
Here you can see the Product Identifier: NAS-PD01ZE with the E
https://products.z-wavealliance.org/products/1671
Here is the one without the E
But im sorry, im not that technical to understand everything... :)
I hope someone is complaining to the vendor about this. It’s not just a OZW issue. It’s going to affect every gateway out there.
You mean, if Neo Coolcam give every product a unique ID then the whole problem is solved?
Have send them a request for near future... lets see what im getting back
@poudenes I may have solved the problem by crafting this config file... Would it be possible to revert your "manuf" file back to the original, then overwrite your nas-pd02z.xml with this version?
https://github.com/petergebruers/open-zwave/blob/nas-pd02z/config/shenzen_neo/nas-pd02z.xml
Then delete your cache file or refresh your nodes
Here you can see the Product Identifier: NAS-PD01ZE with the E
So far I have not looked at the "PD01" device, based on your info and my experience this is about the "PD02" device which has the issues you describe. A similar problem might exist for the older "01" but I have no information. The PD01 and PD2 have different IDs so use different xml files...
I've noticed you started working on the PD02 file but then refer to the PD01 so not sure when that confusion happened...
I hope someone is complaining to the vendor about this. It’s not just a OZW issue. It’s going to affect every gateway out there.
I am not sure how to contact them, this might be their official site
Not a lot info there...
The problem is not new, the PD02 was released "without temperature sensing" quite a while ago and then suddenly versions "with temperature sensor" appeared.
You mean, if Neo Coolcam give every product a unique ID then the whole problem is solved?
Yes, when they change the meaning of parameters or functionality they should do that.
But this will not fix the devices that have been sold... I think the chances of getting firmware updates is pretty slim.
IMHO my version of the config, nas-pd02z.xml, based on your config suggestions (@poudenes ) still improves the situation. But it would be nice if you could test it!
I suddenly realize all posts up to now do not properly explain the main issue and proposed fix.
So with same IDs there is a temperature model and a non-temperature model.
The device flashes a bright LED when it detects motion, and this can be disabled but they used a different parameter for this.
With the current nas-pd02z.xml it is not possible to turn off the LED if you have the newer "temperature" model.
I propose a new config file with these parameters
index="10" label="Ambient Temperature Differential Level Report or Led Blink Enable (0 or 1 - non-temperature version)"
index="11" label="Led Blink Enable (temperature reporting version)"
Parameter 10 is the only "conflicting" parameter but imho that explanation should help. Parameters 11,12 and 99 are new
haha, correct. This explain the conflict correct!
The issue referenced by @sincze is not related, his issue is having device ID 0000 which means the device has not been interviewed yet.
Here's what I will do. I'll wait another day to see if someone either has fundamental objections to the proposed fix, or if someone comes up with new information. If there is no objection, I'll merge it.
If there will be no merge. I know I can update the info myself when I need do a reinstall :)
Hi All,
I found out that the config for Neo Coolcam PIR Motion is not correct
open-zwave/config/shenzen_neo/nas-pd02z.xml
With a other user (he created the new XML) we have all the options for those motion sensors.
We changed the line in manufacturer_specific.xml
<Product config="shenzen_neo/nas-pd02z.xml" id="108d" name="Battery Powered PIR Sensor V2" type="0003"/>
to
<Product config="shenzen_neo/nas-pd02ze.xml" id="108d" name="Battery Powered PIR Sensor V2" type="0003"/>
Added the new nas-pd02ze.xml in shenzen_neo/