OpenZWave / open-zwave

a C++ library to control Z-Wave Networks via a USB Z-Wave Controller.
http://www.openzwave.net/
GNU Lesser General Public License v3.0
1.05k stars 915 forks source link

manufacturer_specific.xml - type and id probably inverted for MHS314 (MCO Home) device #2520

Closed loomyr closed 3 years ago

loomyr commented 3 years ago

Hi, When adding a MCO-Home MH-S314 switch, OZW was unable to detect it correctly :

image

After checking the "_manufacturerspecific.xml" file I figured out that the type and the id of the MCO-Home MH-S314 might be inverted: https://github.com/OpenZWave/open-zwave/blob/776eeda3b571b5f82c77166a60878fa75eb5c499/config/manufacturer_specific.xml#L1229

Based on my device inclusion (attached picture above), I assume it should be referenced like that :

id="5102" name="MH-S314 Four-load" type="3141"

Best Regards, Vincent

stuartwishart commented 3 years ago

I found a similar issue with the MCO MH-S513 definition, see PR #2516