OpenZWave / open-zwave

a C++ library to control Z-Wave Networks via a USB Z-Wave Controller.
http://www.openzwave.net/
GNU Lesser General Public License v3.0
1.05k stars 915 forks source link

MCOHome MH-P220 Scene Activation Not Activating #2576

Open jamesarbrown opened 3 years ago

jamesarbrown commented 3 years ago

This device has capability to trigger a scene ID. However the OZW logs are showing

2021-02-06 17:46:18.872 Detail, Node025,   Received: 0x01, 0x0a, 0x00, 0x04, 0x04, 0x19, 0x04, 0x2b, 0x01, 0x01, 0xff, 0x3c                
2021-02-06 17:46:18.872 Detail,                                                                                                            
2021-02-06 17:46:18.872 Warning, Node025, Received a SceneActivation Message for a Controlled CommandClass                                 
2021-02-06 17:46:18.872 Warning, Node025, CommandClass COMMAND_CLASS_SCENE_ACTIVATION HandlerMsg Returned False    

So looking around and being a cut and paste hero I added this to ./mcohome/mhp220.xml

  <CommandClass id="43" name="COMMAND_CLASS_SCENE_ACTIVATION">                                                                                                                                  
    <Compatibility />                                                                                                                                                                           
    <State>                                                                                                                                                                                     
      <AfterMark>true</AfterMark>                                                                                                                                                               
      <CCVersion>1</CCVersion>                                                                                                                                                                  
      <InNif>true</InNif>                                                                                                                                                                       
      <StaticRequests>4</StaticRequests>                                                                                                                                                        
    </State>                                                                                                                                                                                    
    <Instance index="1" />                                                                                                                                                                      
    <Value type="int" genre="user" instance="1" index="0" label="Scene" units="" read_only="true" write_only="false" verify_changes="false" poll_intensity="0" min="-2147483648" max="2147483647
" value="0">                                                                                                                                                                                    
      <Help>Scene Event</Help>                                                                                                                                                                  
    </Value>                                                                                                                                                                                    
  </CommandClass> 

And had some sucess that the user parameter 43-1-0 field now updates


2021-02-06 17:51:20.164 Detail, Node025,   Received: 0x01, 0x0a, 0x00, 0x04, 0x04, 0x19, 0x04, 0x2b, 0x01, 0x01, 0xff, 0x3c                                                                     
2021-02-06 17:51:20.164 Detail,                                                                                                                                                                 
2021-02-06 17:51:20.164 Info, Node025, Received SceneActivation set from node 25: scene id=1 via configuration. Sending event notification.                                                     
2021-02-06 17:51:20.164 Info, Node025, Received SceneActivation report: 1 (duration: 0)                                                                                                         
2021-02-06 17:51:20.164 Detail, Node025, Initial read of value                                                                                                                                  
2021-02-06 17:51:20.164 Detail, Node025, Initial read of value                                                                                                                                  
2021-02-06 17:51:20.164 Info, Node025, Automatically Clearing SceneID/Duration in 1000 ms                                                                                                       
2021-02-06 17:51:20.165 Info, Timer: adding event in 1000 ms                                                                                                                                    
2021-02-06 17:51:20.165 Detail, Node025, Notification: SceneEvent                                                                                                                               
2021-02-06 17:51:20.165 Detail, Timer: waiting with timeout 1000 ms                                                                                                                             
  z2m:Zwave scene event 25 0 +18s                                                                                                                                                               
2021-02-06 17:51:20.167 Detail, Node025, Notification: ValueChanged CC: COMMAND_CLASS_SCENE_ACTIVATION Instance: 1 Index: 0                                                                     
2021-02-06 17:51:20.167 Detail, Node025, Notification: ValueChanged CC: COMMAND_CLASS_SCENE_ACTIVATION Instance: 1 Index: 1                                                                     
  z2m:Zwave zwave node 25: changed: 43-1-0:Scene:0 -> 1 +3ms                                                                                                                                    
  z2m:Zwave zwave node 25: changed: 43-1-1:Duration:0 -> 0 +3ms                                                                                                                                 
2021-02-06 17:51:21.165 Info, Timer: delayed event                                                                                                                                              
2021-02-06 17:51:21.165 Detail, Node025, Value Updated: old value=1, new value=0, type=int                                                                                                      
2021-02-06 17:51:21.165 Detail, Node025, Changes to this value are not verified                                                                                                                 
2021-02-06 17:51:21.165 Detail, Node025, Value Updated: old value=0, new value=0, type=int                                                                                                      
2021-02-06 17:51:21.165 Detail, Node025, Changes to this value are not verified                                                                                                                 
2021-02-06 17:51:21.165 Detail, Timer: waiting with timeout -1 ms                                                                                                                               
2021-02-06 17:51:21.166 Detail, Node025, Notification: ValueChanged CC: COMMAND_CLASS_SCENE_ACTIVATION Instance: 1 Index: 0                                                                     
  z2m:Zwave zwave node 25: changed: 43-1-0:Scene:1 -> 0 +995ms                                                                                                                                  
2021-02-06 17:51:21.166 Detail, Node025, Notification: ValueRefreshed CC: COMMAND_CLASS_SCENE_ACTIVATION Instance: 1 Index: 1                                                                   
  z2m:Zwave zwave node 25: changed: 43-1-1:Duration:0 -> 0 +2ms  

But it never triggers this working scene thats in zwave2mqtt (which works by the activate button). So I never concluded fixing the core bug

image