search

OpenZWave / open-zwave

a C++ library to control Z-Wave Networks via a USB Z-Wave Controller.
http://www.openzwave.net/
GNU Lesser General Public License v3.0
1.05k stars 918 forks source link

Support for Goodway In wall relay #2619

Open tszalaj opened 2 years ago

tszalaj commented 2 years ago

I created a configuration file for Goodway In wall switch using documentation provided on webpage: https://products.z-wavealliance.org/products/2948. I've tested it with the device on Domoticz. Configuration works and device reports it's outputs state changes.

nechry commented 2 years ago

@tszalaj can you fix the xlmtest errors

Error: /home/runner/work/open-zwave/open-zwave/config/goodway/tc13010.xml:21: element Value: Schemas validity error : Element '{https://github.com/OpenZWave/open-zwave}Value', attribute 'unit': The attribute 'unit' is not allowed.
Error: /home/runner/work/open-zwave/open-zwave/config/goodway/tc13010.xml:24: element Value: Schemas validity error : Element '{https://github.com/OpenZWave/open-zwave}Value', attribute 'unit': The attribute 'unit' is not allowed.
Error: /home/runner/work/open-zwave/open-zwave/config/goodway/tc13010.xml:38: element Value: Schemas validity error : Element '{https://github.com/OpenZWave/open-zwave}Value', attribute 'unit': The attribute 'unit' is not allowed.
Error: /home/runner/work/open-zwave/open-zwave/config/goodway/tc13010.xml:41: element Value: Schemas validity error : Element '{https://github.com/OpenZWave/open-zwave}Value', attribute 'unit': The attribute 'unit' is not allowed.
Error: /home/runner/work/open-zwave/open-zwave/config/goodway/tc13010.xml:44: element Value: Schemas validity error : Element '{https://github.com/OpenZWave/open-zwave}Value', attribute 'unit': The attribute 'unit' is not allowed.
Error: /home/runner/work/open-zwave/open-zwave/config/goodway/tc13010.xml:47: element Value: Schemas validity error : Element '{https://github.com/OpenZWave/open-zwave}Value', attribute 'unit': The attribute 'unit' is not allowed.
Error: /home/runner/work/open-zwave/open-zwave/config/goodway/tc13010.xml:50: element Value: Schemas validity error : Element '{https://github.com/OpenZWave/open-zwave}Value', attribute 'unit': The attribute 'unit' is not allowed.
Error: /home/runner/work/open-zwave/open-zwave/config/goodway/tc13010.xml:71: element CommandClass: Schemas validity error : Element '{https://github.com/OpenZWave/open-zwave}CommandClass', attribute 'ForceInstances': The attribute 'ForceInstances' is not allowed.

run make xmltest to valid it, and then update your PR, thank-you

unit=>units