search

OpenZWave / qt-openzwave

QT5 Wrapper for OpenZWave
GNU Lesser General Public License v3.0
105 stars 30 forks source link

Inconsistent final event states when cancelling some commands #122

Closed kpine closed 2 years ago

kpine commented 4 years ago

I did both addnode and removenode commands and cancelled them. The addnode final event state was "Completed", while the removenode was "Cancel". I would expect cancelled for both. The add does show the cancelled state but it's the second to last. I did not try any other commands. Here's a trace of the commands:

Add

{"tst":1594099720,"topic":"OpenZWave/2/event/addnode/","qos":0,"retain":0,"payloadlen":51,"payload":{
    "status": "ok",
    "TimeStamp": 1594099720
}}
{"tst":1594099720,"topic":"OpenZWave/2/event/addnode/","qos":0,"retain":0,"payloadlen":67,"payload":{
    "State": "Ctrl_State_Starting",
    "TimeStamp": 1594099720
}}
{"tst":1594099720,"topic":"OpenZWave/2/event/addnode/","qos":0,"retain":0,"payloadlen":66,"payload":{
    "State": "Ctrl_State_Waiting",
    "TimeStamp": 1594099720
}}
{"tst":1594099730,"topic":"OpenZWave/2/event/cancelcontrollercommand/","qos":0,"retain":0,"payloadlen":51,"payload":{
    "status": "ok",
    "TimeStamp": 1594099730
}}
{"tst":1594099730,"topic":"OpenZWave/2/event/addnode/","qos":0,"retain":0,"payloadlen":82,"payload":{
    "Node": 255,
    "State": "Ctrl_State_Cancel",
    "TimeStamp": 1594099730
}}
{"tst":1594099730,"topic":"OpenZWave/2/event/addnode/","qos":0,"retain":0,"payloadlen":85,"payload":{
    "Node": 255,
    "State": "Ctrl_State_Completed",
    "TimeStamp": 1594099730
}}

Remove:

{"tst":1594099751,"topic":"OpenZWave/2/event/removenode/","qos":0,"retain":0,"payloadlen":51,"payload":{
    "status": "ok",
    "TimeStamp": 1594099751
}}
{"tst":1594099751,"topic":"OpenZWave/2/event/removenode/","qos":0,"retain":0,"payloadlen":67,"payload":{
    "State": "Ctrl_State_Starting",
    "TimeStamp": 1594099751
}}
{"tst":1594099751,"topic":"OpenZWave/2/event/removenode/","qos":0,"retain":0,"payloadlen":66,"payload":{
    "State": "Ctrl_State_Waiting",
    "TimeStamp": 1594099751
}}
{"tst":1594099758,"topic":"OpenZWave/2/event/cancelcontrollercommand/","qos":0,"retain":0,"payloadlen":51,"payload":{
    "status": "ok",
    "TimeStamp": 1594099758
}}
{"tst":1594099758,"topic":"OpenZWave/2/event/removenode/","qos":0,"retain":0,"payloadlen":82,"payload":{
    "Node": 255,
    "State": "Ctrl_State_Cancel",
    "TimeStamp": 1594099758
}}