Closed kpine closed 2 years ago
I realized I've been running custom builds lately, so I think that causes my ozwd version to be 0.1.0. Feel free to close if you think the version info is good enough.
I think it would be nice to capture the Git revisions somewhere in the docker image, via ENV or BUILD_ARG or LABEL at least.
qt-openzwave and ozwdaemon versions are hardcoded, as 1.2.0 and 0.1.0 respectively. At would be useful to have actual version numbers.
It can be difficult to tell which version of a container you are using, especially if you're using the latest tags. A version number that changed for each container build and was captured in the container image (e.g. BUILD_ARG, ENV, or LABEL) would be helpful.
It least for ozwdaemon, tagging the current code and using
git describe
would provide a simple version string that could also be used by the Dockerfile. I'm sure there are other ways, but that's what comes to mind.It would also be beneficial to add the git sha info to the OpenZwave version as well, since the build is pulling from "master" which is not a fixed point.