search

OpenZWave / qt-openzwave

QT5 Wrapper for OpenZWave
GNU Lesser General Public License v3.0
105 stars 30 forks source link

DESTDIR not honored during `make install`. #142

Open sofar opened 4 years ago

sofar commented 4 years ago

Common convention is to honor DESTDIR such that package builders can properly handle code. This shouldn't happen:

$ make install DESTDIR=`pwd -P`/FOO
cd qt-openzwave/ && ( test -e Makefile || /usr/bin/qmake -o Makefile /home/sofar/git/qt-openzwave/qt-openzwave/qt-openzwave.pro ) && make -f Makefile install
make[1]: Entering directory '/home/sofar/git/qt-openzwave/qt-openzwave'
/usr/bin/qmake -install qinstall -exe libqt-openzwave.so.1.2.0 /usr/lib64/libqt-openzwave.so.1.2.0
Error copying libqt-openzwave.so.1.2.0 to /usr/lib64/libqt-openzwave.so.1.2.0: Cannot create /usr/lib64/libqt-openzwave.so.1.2.0 for output
make[1]: *** [Makefile:1415: install_target] Error 3
make[1]: Leaving directory '/home/sofar/git/qt-openzwave/qt-openzwave'
make: *** [Makefile:73: sub-qt-openzwave-install_subtargets-ordered] Error 2

Thousands of packages honor DESTDIR, fixing this will help distro integration a lot.