OpenZWave / qt-openzwave

QT5 Wrapper for OpenZWave
GNU Lesser General Public License v3.0
105 stars 30 forks source link

Controller operations should support timeouts #176

Closed kpine closed 2 years ago

kpine commented 4 years ago

If you issue an Add or Remove node command, ozwdaemon will wait forever as long as no device triggers an add or remove. During this time no z-wave commands from clients will be processed, instead they are queued for later. There should be a mechanism to timeout the commands if not completed within a set time interval. Preferably ozwdaemon would provide for a default timeout, and optionally take a timeout parameter via the API.

For example, zwave2mqtt implements this in its own application logic. The Home Assistant OZW Integration has no such timeout, and commands will wait forever. The latter has led to some user confusion.

I believe the z-wave spec (500 series application programming guide) requires a timeout and suggests a maximum of 60 seconds.

Or, this might be more appropriate for the open-zwave library to take responsibility for, so all library clients can take advantage of it w/o having to re-implement it.