search

OpenZWave / qt-openzwave

QT5 Wrapper for OpenZWave
GNU Lesser General Public License v3.0
105 stars 30 forks source link

Update mqtt node entry on name change #77

Closed lifeisafractal closed 4 years ago

lifeisafractal commented 4 years ago

Currently when a name change event comes in for a node the even is updated in the MQTT node topic, but the actual data isn't update (NodeName in the json data). This allows for changes made to node names at run time (for example with ozw-admin) to propagate through to clients of the MQTT interface like Home Assistant without restarting.

Fishwaldo commented 4 years ago

Thanks!

The NodeNaming Notification will probably go away in 1.7 as its a optional commandclass that very few devices support now days (unfortuantly) and NodeNames will only be exposed if a device supports the CommandClass. But this is good for 1.6

lifeisafractal commented 4 years ago

@Fishwaldo I didn't realize that the NoneName was mainly to support the node naming CommandClass. I didn't know about that before and as you pointed out, none of my devices support it. My motivation with using the node naming is so I can give a useful name to nodes within my network which is pretty essential for managing the network and know whwat's what. It's also convenient that downstream clients of OZW (like Home Assistant) can use this node name when choose how it shows up.

Since this is likely going away in 1.7, what is going to be the supported method of giving a human readable name to nodes in an Open ZWave network?

Edit: Also, thanks for all the hard work on QtOpenZwave. This is very exciting stuff. I'm try to get to a point where I'm running of git versions of everything and can start wrapping my head around things so I can contribute more to the development.