ERC721 URI Storage - Githubissues

OpenZeppelin / cairo-contracts

OpenZeppelin Contracts written in Cairo for Starknet, a decentralized ZK Rollup

https://docs.openzeppelin.com/contracts-cairo

MIT License

797 stars 322 forks source link

ERC721 URI Storage #1031

Open gerceboss opened 3 days ago

gerceboss commented 3 days ago

Resolves #1019

Added extension's component implementation, mock contract, tests and updated documentation Purpose: Adding ERC721URIstorage extension to OZ.

PR Checklist

[x] Tests
[x] Documentation
[ ] Added entry to CHANGELOG.md
[ ] Tried the feature on a public network

andrew-fleming commented 3 days ago

the tests are not running on scarb test.

The new tests or all tests? If the latter, are you in the package root (cairo-contracts) when running the test command?

gerceboss commented 3 days ago

@andrew-fleming , they were running but it was not showing any errors on my local machine. When I opened the pull request three of them were failing and the tests were running. I have committed the changes and all the tests are passing right now . Let me know if more tests are needed.

gerceboss commented 1 day ago

@immrsd, @andrew-fleming , can you please review if any other changes are required?